• BillyClark@piefed.social
    link
    fedilink
    English
    arrow-up
    11
    ·
    1 day ago

    It’s a bit of a change of mindset to begin thinking that you can’t trust a PR even a little.

    It has never occurred to me that other people trust PRs, even a little. I mean, that they might think about it in those terms.

    This explains a lot to me.

    Why does it take me longer to review code than other people? They trust the person who wrote it, but I don’t.

    Why is it that when my coworkers think a person is untrustworthy, that they always end up begging me to do all of that person’s reviews. It’s because I’m not bothered by that. I already treat everybody as untrustworthy.

    I’ve never understood how other people think when they do reviews, I guess.

    • fibojoly@sh.itjust.works
      link
      fedilink
      arrow-up
      3
      ·
      15 hours ago

      The way I see it, if you bother me to do a PR, you bet I will give it my 100% Either that or I just refuse to do it.
      Half-assing it would only hurt my image. And then it would be a bother because whatever I didn’t catch would very probably be some shit I would have to hunt down anyway later down the line since I’m the guy they escalate things to in the team :/